-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade the exporter to support OpenSearch 2.12.0 #250
Conversation
I need to look at it, it might be related to java version used in CI. Currently, it is JDK 14 |
Hi @lukas-vlcek, |
I am on it... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cesium147 I had to do one merge from |
@cesium147 What happened is that I had to upgrade to gradle 8.5 and at the same time I upgraded CI to JDK 17. See https://github.com/Aiven-Open/prometheus-exporter-plugin-for-opensearch/pull/253/commits Do you think you can open a new PR and we will close this one? I am not really sure what is going on. I should not have been using GitHub web UI to manipulate commits... I am sorry. If you create a new PR, you can add the Java 21 to the CI array like this:
Or you can keep it just on Java 17. Both should be ok. Other than that the upgrade is looking good. |
Signed-off-by: cesium147 <[email protected]>
Signed-off-by: cesium147 <[email protected]>
Great, thanks @cesium147 ! |
Thank you all for your work on this. We love upgrading and the exporter is a critical piece of it. |
FYI: Plugin version |
Description
Describe your PR and add links to relevant issues.
DCO stands for Developer Certificate of Origin and it is your declaration that your contribution is correctly attributed and licensed. Please read more about how to attach DCO to your commits here (spoiler alert: in most cases it is as simple as using
-s
option when doinggit commit
).Please be aware that commits without DCO will cause failure of PR CI workflow and can not be merged.